This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
Change miner.Sectors AMT bitwidth to 5. Move constants to state files. #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll ensure @ZenGround0 reviews this after break, but would like to merge so we can build on top of it. |
Codecov Report
@@ Coverage Diff @@
## master #1333 +/- ##
======================================
Coverage 70.0% 70.0%
======================================
Files 72 72
Lines 7346 7346
======================================
Hits 5148 5148
Misses 1354 1354
Partials 844 844 |
Stebalien
approved these changes
Dec 17, 2020
bibibong
pushed a commit
to EpiK-Protocol/go-epik-actors
that referenced
this pull request
Feb 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ZenGround0 's benchmarks indicate that the best bitwidth for
miner.Sectorsis 5. I think they accidentally wrote 6 in #1328, which was easy to miss.I also moved the constants consistently into the
_state.gofiles, rather thanpolicy.go.