Skip to content
This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
This repository has been archived by the owner on Jun 6, 2023. It is now read-only.

Remove runtime access from market actor state methods #455

Open
@anorth

Description

The Runtime interface is large and dependencies on it should be restricted in order to enable testability. Ideally, access should be restricted only to top-level exported actor methods, though there are some cases where its justified to plumb a little deeper. It is often passed merely for access to the Abortf method, as an alternative to canonical Go error propagation.

The market.State object is one such place with rampant use of the Runtime only for aborting. This makes the state mutations much harder to test, and indeed they are largely untested (14% coverage).

Purge use of the runtime from this code.

Metadata

Assignees

No one assigned

    Labels

    P3Not urgent or importantcleanupTechnical debt recovery and other cleanup workcode-readyReady for implementation, with clear path

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions