Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimistic file upload #717

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

feat: optimistic file upload #717

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3907b5b
feat: add files to data page while waiting on upload
akuokojnr Apr 12, 2021
5e005c9
fix: double rendering issues
akuokojnr Apr 16, 2021
7062d60
feat: disable sidebar action for optimistic files
akuokojnr Apr 19, 2021
40b44ff
chore: add comment
akuokojnr Apr 19, 2021
5d2a8d0
fix: handle failed state
akuokojnr Apr 21, 2021
593692c
fix: preview for pdf files
akuokojnr Apr 21, 2021
9e4de33
fix: show spinner in table view
akuokojnr Apr 21, 2021
b43799b
fix: update viewer func
akuokojnr Apr 21, 2021
eeec7b5
fix: rebase conflicts
akuokojnr Apr 26, 2021
45ff551
fix: disable carouselsidebar action for optimistic files
akuokojnr Apr 26, 2021
bc0514d
feat: add optimistic upload to collection page
akuokojnr Apr 26, 2021
23cb5a4
fix: optimistic upload on collection page
akuokojnr Apr 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: add comment
  • Loading branch information
@akuokojnr
akuokojnr committed Apr 26, 2021
commit 40b44ff482cac9a48622de890d21e60f48cb34aa
3 changes: 2 additions & 1 deletion components/core/Application.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ export default class ApplicationPage extends React.Component {
}

if (newViewerState.library?.length) {
// NOTE(daniel): update optimistic files with upload data
let oldViewerState = this.state.viewer;
let oldLibrary = oldViewerState.library;

Expand Down Expand Up @@ -380,7 +381,7 @@ export default class ApplicationPage extends React.Component {
}

files = await this._handleOptimisticUpload({ files });
return;

const resolvedFiles = [];
for (let i = 0; i < files.length; i++) {
if (Store.checkCancelled(`${files[i].lastModified}-${files[i].name}`)) {
Expand Down