fix: make flush match lotus as much as possible #586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Reject anything we don't expect. 2. Properly handle identity cids.
12 tasks
arajasek
reviewed
May 24, 2022
magik6k
approved these changes
May 24, 2022
Contributor
magik6k
left a comment
magik6k
left a comment
There was a problem hiding this comment.
Other than the nitpick in the comment, nothing here looks wrong.
Co-authored-by: Aayush Rajasekaran <arajasek94@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're also checking the hash function (only allowing blake2b). I could drop that, but it seems like a reasonable sanity check.