This repository was archived by the owner on Oct 31, 2023. It is now read-only.
Add constructors for G1Compressed/G2Compressed #28
+91
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
force-pushed
the
G12Compressed-constructors
branch
from
3ee8e70 to
6fe4bdb
Compare
|
I think it would be good to instead of using the |
|
Yeah, makes sense. I adapted the PR accordingly. |
dignifiedquire
suggested changes
May 14, 2021
src/bls12_381/ec/g1.rs
Outdated
| @@ -193,6 +193,12 @@ impl fmt::Debug for G1Compressed { | |||
| } | |||
| } | |||
|
|
|||
| impl G1Compressed { | |||
| fn from_bytes_unchecked(original: [u8; 48]) -> Self { | |||
There was a problem hiding this comment.
these need to be declared pub, otherwise nobody can use them.
can you also add a doc string descring what this does please
There was a problem hiding this comment.
Done. Hope those docs are helpful. Let me know if something is missing or misleading.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17
Closes #23
This is an alternative to #23. It is probably a bit more idiomatic and keeps
G1Compressed/G2Compressed's data internal.