[nv16] propagate gas outputs from fvm + integrate safer ffi #8593
Conversation
vyzo
force-pushed
the
fix/nv16-gas-outputs
branch
2 times, most recently
from
3b6be70 to
a9b72d5
Compare
raulk
left a comment
raulk
left a comment
There was a problem hiding this comment.
Tests that are failing are already failing.
| require.Equal(t, "baga6ea4seaqonenxyku4o7hr5xkzbqsceipf6xgli3on54beqbk6k246sbooobq", c.PieceCID.String()) | ||
| } | ||
|
|
||
| func setupLogger(t *testing.T) *bytes.Buffer { |
There was a problem hiding this comment.
Could you explain why this needs to go entirely? I understand that generated no longer exists, but has all this functionality vanished from the library? Or is it just behind different APIs? If the latter, we should adapt the tests, not drop the coverage.
There was a problem hiding this comment.
its gone completely afaict.
There was a problem hiding this comment.
It isn't. AFAIK no functionality has been removed, only APIs have changed. Here's where the log is now:
There was a problem hiding this comment.
ok feel free to reinstate, it is really ugly however.
There was a problem hiding this comment.
Agreed that the form of the test is terrible, but it is providing certain coverage that we can't drop here.
raulk
force-pushed
the
fix/nv16-gas-outputs
branch
3 times, most recently
from
5963613 to
24e68fe
Compare
raulk
force-pushed
the
fix/nv16-gas-outputs
branch
from
1699d55 to
24e68fe
Compare
raulk
force-pushed
the
fix/nv16-gas-outputs
branch
from
50825e4 to
b4dae33
Compare
raulk
changed the title
See filecoin-project/ref-fvm#523
Depends on filecoin-project/filecoin-ffi#275
Integrates filecoin-project/filecoin-ffi#247.