Use new go-state-types state accessors #8534
Conversation
arajasek
force-pushed
the
asr/refactor
branch
8 times, most recently
from
c50a8c0 to
84af8da
Compare
arajasek
force-pushed
the
asr/refactor
branch
3 times, most recently
from
a1761d2 to
cc454aa
Compare
| api "github.com/filecoin-project/lotus/api" | ||
| apitypes "github.com/filecoin-project/lotus/api/types" | ||
| miner "github.com/filecoin-project/lotus/chain/actors/builtin/miner" | ||
| miner0 "github.com/filecoin-project/lotus/chain/actors/builtin/miner" |
| apitypes "github.com/filecoin-project/lotus/api/types" | ||
| v0api "github.com/filecoin-project/lotus/api/v0api" | ||
| miner "github.com/filecoin-project/lotus/chain/actors/builtin/miner" | ||
| miner0 "github.com/filecoin-project/lotus/chain/actors/builtin/miner" |
arajasek
force-pushed
the
asr/refactor
branch
8 times, most recently
from
d482aa0 to
e555d89
Compare
vyzo
left a comment
vyzo
left a comment
There was a problem hiding this comment.
looks pretty good, just some small nits.
Also, shouldn't we do something about genesis (for tests)?
api/api_full.go
Outdated
| HasMinPower bool | ||
| } | ||
|
|
||
| type MinerInfo struct { |
There was a problem hiding this comment.
move this with the other typedefs?
There was a problem hiding this comment.
The JSON-RPC API struct is different to state struct, I think. I think it's fine here.
There was a problem hiding this comment.
I meant to api/types.go, that's the logical place where it belongs.
There was a problem hiding this comment.
A bunch of the api types are already in api_full.go, but I think i agree with @vyzo -- moving.
chain/actors/builtin/builtin.go
Outdated
|
|
||
| case builtin8.IsBuiltinActor(c): | ||
| return builtin8.ActorNameByCode(c) | ||
| case builtin8sa.IsBuiltinActor(c): |
There was a problem hiding this comment.
just builtin8 to be consistent?
| builtin{{.}} "github.com/filecoin-project/specs-actors{{import .}}actors/builtin" | ||
| {{else}} | ||
| builtin{{.}} "github.com/filecoin-project/go-state-types/builtin" | ||
| builtin{{.}}sa "github.com/filecoin-project/specs-actors{{import .}}actors/builtin" |
| {{if (le . 7)}} | ||
| case builtin{{.}}.IsBuiltinActor(c): | ||
| return builtin{{.}}.ActorNameByCode(c) | ||
| {{else}} |
There was a problem hiding this comment.
I dont think we either need or want this branch.
After v8 it should always be in the manifest and gst should have no knowledge of this.
There was a problem hiding this comment.
I'm not sure I know exactly what you mean here -- what are you proposing dropping?
api/api_full.go
Outdated
| HasMinPower bool | ||
| } | ||
|
|
||
| type MinerInfo struct { |
There was a problem hiding this comment.
The JSON-RPC API struct is different to state struct, I think. I think it's fine here.
| case actors.Version0: | ||
| return load0(store, act.Head) | ||
|
|
||
| case actors.Version2: | ||
| return load2(store, act.Head) | ||
|
|
||
| case actors.Version3: | ||
| return load3(store, act.Head) | ||
|
|
||
| case actors.Version4: | ||
| return load4(store, act.Head) | ||
|
|
||
| case actors.Version5: | ||
| return load5(store, act.Head) | ||
|
|
||
| case actors.Version6: | ||
| return load6(store, act.Head) | ||
|
|
||
| case actors.Version7: | ||
| return load7(store, act.Head) | ||
|
|
There was a problem hiding this comment.
Is this removing support for loading and managing actor state pre-v8?
There was a problem hiding this comment.
No, this is code that was added in this commit , but I feel like this wasn't the right thing to do -- we shouldn't be relying on the ActorMeta to tell us anything about versions 0-7. The former codeCid-based switch (directly after this) works for those cases.
@vyzo This PR makes all genesis happen through the FVM (for actors v8 onwards). Anything else you wanted to see happen for it? |
|
no, thats what we want! |
vyzo
left a comment
vyzo
left a comment
There was a problem hiding this comment.
modulo resolving that else branch.
arajasek
force-pushed
the
asr/refactor
branch
2 times, most recently
from
d924c8a to
f0b3d21
Compare
Resolves #8063
This PR replaces uses of the specs-actors v8 repo in Lotus and (most of) its deps. The current specs-actors v8 is not the specification of Filecoin actors, and mostly there for prototyping and convenience. This PR integrates actor state types and params from go-state-types.
There are 2 remaining uses of actors v8:
Needs