Skip to content

Conversation

@aarshkshah1992
Copy link
Contributor

@aarshkshah1992 aarshkshah1992 commented Jan 23, 2022

@aarshkshah1992 aarshkshah1992 requested a review from a team as a code owner January 23, 2022 06:05
@aarshkshah1992 aarshkshah1992 marked this pull request as draft January 23, 2022 06:05
@aarshkshah1992 aarshkshah1992 changed the base branch from master to feat/cid-to-piece-idx January 23, 2022 06:06
@codecov
Copy link

codecov bot commented Jan 23, 2022

Codecov Report

Merging #7990 (57dac73) into feat/cid-to-piece-idx (7508d96) will increase coverage by 0.32%.
The diff coverage is 97.22%.

Impacted file tree graph

@@                    Coverage Diff                    @@
##           feat/cid-to-piece-idx    #7990      +/-   ##
=========================================================
+ Coverage                  38.89%   39.21%   +0.32%     
=========================================================
  Files                        662      662              
  Lines                      71622    71640      +18     
=========================================================
+ Hits                       27855    28097     +242     
+ Misses                     38949    38697     -252     
- Partials                    4818     4846      +28     
Impacted Files Coverage Δ
extern/sector-storage/sealtasks/task.go 81.81% <ø> (ø)
itests/kit/deals.go 77.13% <ø> (ø)
extern/sector-storage/manager.go 61.29% <75.00%> (ø)
extern/sector-storage/ffiwrapper/sealer_cgo.go 59.56% <100.00%> (ø)
extern/sector-storage/mock/mock.go 61.35% <100.00%> (+0.10%) ⬆️
extern/sector-storage/piece_reader.go 63.33% <100.00%> (+4.58%) ⬆️
itests/kit/ensemble.go 91.24% <100.00%> (ø)
itests/kit/ensemble_opts.go 100.00% <100.00%> (ø)
markets/dagstore/wrapper.go 78.02% <100.00%> (+0.19%) ⬆️
node/modules/storageminer.go 63.62% <100.00%> (+0.05%) ⬆️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7508d96...57dac73. Read the comment docs.

@aarshkshah1992 aarshkshah1992 self-assigned this Jan 23, 2022
@magik6k magik6k force-pushed the feat/cid-to-piece-idx branch from 1db0f8a to 7dcfeee Compare March 3, 2022 14:17
Base automatically changed from feat/cid-to-piece-idx to master March 3, 2022 16:50
@jennijuju
Copy link
Member

@aarshkshah1992 are you still working on it?

@rjan90
Copy link
Contributor

rjan90 commented May 28, 2024

Closing after approval to close this from @aarshkshah1992

@rjan90 rjan90 closed this May 28, 2024
@rjan90 rjan90 deleted the feat/bitswap-support branch May 28, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants