Test multicore SDR support #6479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great bias for action here @magik6k! Thanks for finding a way to catch this early and prevent more manual effort. |
magik6k
force-pushed
the
test/multicore-sdr
branch
from
9e7eca5
to
265afd6
Compare
arajasek
approved these changes
Jun 15, 2021
jennijuju
approved these changes
Jun 15, 2021
jennijuju
reviewed
Jun 15, 2021
|
|
||
| ok := false | ||
| for _, s := range strings.Split(rustLogger.String(), "\n") { | ||
| if strings.Contains(s, "create_label::multi") { |
There was a problem hiding this comment.
can this be used as a hard ✅ ? when the things was down during the weekend, a miner reported that in his log its showing multi-core however, single-core was used in reality
There was a problem hiding this comment.
Yeah, this tests that the multicore feature works. If it uses only a single core, then that's a separate bug, and I'm not sure if we have a good way to test that from Go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test works when run individually, but broken when it runs with any other tests as proofs expect the call to FilInitLogFd to be the very first proofs call.
Probably acceptable to work around by just running this test individually in a separate step on Circle