Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel fetch for chain sync #3887

Merged
merged 11 commits into from
Sep 23, 2020
Merged

Parallel fetch for chain sync #3887

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
61c0b8c
properly close streams in blocksync
vyzo Sep 16, 2020
35f6e10
parallel chain sync
vyzo Sep 16, 2020
05a233f
add some more logging
vyzo Sep 16, 2020
b984e94
fix bug
vyzo Sep 16, 2020
8a4b629
increase sync request batch size to 8
vyzo Sep 16, 2020
2a428f0
increase exchange ShufflePeersPrefix to 16, use that as the value of …
vyzo Sep 16, 2020
fb605f6
refactor parallel fetch logic into a separate function
vyzo Sep 17, 2020
d7948fc
fix log; we want to log time when we succeed!
vyzo Sep 17, 2020
2946561
clean up return code
vyzo Sep 17, 2020
6dfc40a
error is nil at end, so return batch, nil
vyzo Sep 17, 2020
f135ec8
fix handling of end of sync
vyzo Sep 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clean up return code
  • Loading branch information
@vyzo
vyzo committed Sep 17, 2020
commit 2946561decdb7bd7b9056cc256c6e32294a13279
7 changes: 4 additions & 3 deletions chain/sync.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1593,11 +1593,12 @@ func (syncer *Syncer) fetchMessages(ctx context.Context, headers []*types.TipSet
}
wg.Wait()

if batchErr == nil {
dt := build.Clock.Since(start)
log.Infof("fetching messages for %d tipsets at %d done; took %s", batchSize, startOffset, dt)
if batchErr != nil {
return nil, batchErr
}

log.Infof("fetching messages for %d tipsets at %d done; took %s", batchSize, startOffset, build.Clock.Since(start))

return batch, batchErr
}

Expand Down