Merge pull request #10912 from simlecode/fix/not-unlock

fix: not call RUnlock
filecoin-project · May 23, 2023 · f99fbc1 · f99fbc1
2 parents 6b4a46d + 6ec413b
commit f99fbc1
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/chain/messagepool/check.go b/chain/messagepool/check.go
@@ -35,6 +35,7 @@ func (mp *MessagePool) CheckPendingMessages(ctx context.Context, from address.Ad
 	mp.lk.RLock()
 	mset, ok, err := mp.getPendingMset(ctx, from)
 	if err != nil {
+		mp.lk.RUnlock()
 		return nil, xerrors.Errorf("errored while getting pending mset: %w", err)
 	}
 	if ok {
@@ -70,6 +71,7 @@ func (mp *MessagePool) CheckReplaceMessages(ctx context.Context, replace []*type
 			msgMap[m.From] = mmap
 			mset, ok, err := mp.getPendingMset(ctx, m.From)
 			if err != nil {
+				mp.lk.RUnlock()
 				return nil, xerrors.Errorf("errored while getting pending mset: %w", err)
 			}
 			if ok {
@@ -153,6 +155,7 @@ func (mp *MessagePool) checkMessages(ctx context.Context, msgs []*types.Message,
 			mp.lk.RLock()
 			mset, ok, err := mp.getPendingMset(ctx, m.From)
 			if err != nil {
+				mp.lk.RUnlock()
 				return nil, xerrors.Errorf("errored while getting pending mset: %w", err)
 			}
 			if ok && !interned {