add storage group documentation under seal-workers #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnymatthews
suggested changes
Dec 3, 2021
Contributor
johnnymatthews
left a comment
johnnymatthews
left a comment
There was a problem hiding this comment.
This is a great PR, thanks for submitting! I've suggested a few changes, mainly based around formatting and minor grammar issues. I've not commited them yet, since I think it'd be good for you to take a look and understand the changes I've made.
LexLuthr
commented
Dec 6, 2021
Collaborator
Author
LexLuthr
left a comment
LexLuthr
left a comment
There was a problem hiding this comment.
I have added comments on 2 changes. Everything else looks better than before. Thank you for helping me fix this. I think we are good to merge after you review my 2 comments.
johnnymatthews
approved these changes
Dec 6, 2021
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30
The documentation details how storage groups can be used to reduce the data movement by assigning the sealing steps to a fixed group of nodes with access to already processed data.