Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration for transient data for nv25 #340

Merged
merged 18 commits into from
Jan 30, 2025
Merged

Conversation

snissn
Copy link
Contributor

@snissn snissn commented Jan 26, 2025

No description provided.

@snissn snissn requested a review from rjan90 January 26, 2025 19:47
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 179 lines in your changes missing coverage. Please review.

Project coverage is 3.39%. Comparing base (5f30872) to head (f37e2b7).

Files with missing lines Patch % Lines
builtin/v16/evm/cbor_gen.go 0.00% 124 Missing ⚠️
builtin/v16/migration/evm.go 0.00% 36 Missing ⚠️
builtin/v16/migration/top.go 0.00% 17 Missing ⚠️
builtin/v16/gen/gen.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #340      +/-   ##
==========================================
- Coverage    3.39%    3.39%   -0.01%     
==========================================
  Files         662      663       +1     
  Lines      177834   178012     +178     
==========================================
  Hits         6041     6041              
- Misses     169944   170122     +178     
  Partials     1849     1849              
Files with missing lines Coverage Δ
builtin/v16/evm/evm_state.go 0.00% <ø> (ø)
builtin/v16/gen/gen.go 0.00% <0.00%> (ø)
builtin/v16/migration/top.go 0.00% <0.00%> (ø)
builtin/v16/migration/evm.go 0.00% <0.00%> (ø)
builtin/v16/evm/cbor_gen.go 0.00% <0.00%> (ø)

@snissn snissn requested a review from rvagg January 26, 2025 19:52
@rjan90 rjan90 changed the title Migration for transient data for nv16 Migration for transient data for nv25 Jan 27, 2025
@rjan90 rjan90 linked an issue Jan 27, 2025 that may be closed by this pull request
@snissn snissn changed the title Migration for transient data for nv25 Migration for transient data for nv25 [skip changelog] Jan 27, 2025
@snissn snissn changed the title Migration for transient data for nv25 [skip changelog] Migration for transient data for nv25 Jan 27, 2025
@rjan90
Copy link
Contributor

rjan90 commented Jan 28, 2025

@snissn looks like the branch is a bit out-of-date with the base branch, do you mind updating it with the latest changes?

@rvagg
Copy link
Member

rvagg commented Jan 29, 2025

@snissn I went back to the FIP to cross-check but realised we never got the finer details put into that because it was mostly fleshed out in builtin-actors. I made an issue in the FIPs repo to get those filled in, it should be fairly simple to do and I made a proposed list as a starter: filecoin-project/FIPs#1110

@rvagg
Copy link
Member

rvagg commented Jan 29, 2025

functionally this is 👌 , just some minor non-functional nits left in comments

snissn and others added 2 commits January 29, 2025 12:03
Co-authored-by: Rod Vagg <rod@vagg.org>
Co-authored-by: Rod Vagg <rod@vagg.org>
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely

@rjan90 rjan90 merged commit fe7cb49 into master Jan 30, 2025
8 checks passed
@rjan90 rjan90 deleted the mikers/transient_data_nv16 branch January 30, 2025 07:12
@snissn
Copy link
Contributor Author

snissn commented Jan 30, 2025

thanks @rvagg !!

@snissn
Copy link
Contributor Author

snissn commented Jan 30, 2025

Thanks for merging @rjan90 !!

@rjan90
Copy link
Contributor

rjan90 commented Jan 30, 2025

@snissn I´m in the process of cutting a release here: #342, will mention it in your PR here filecoin-project/lotus#12849 once it is cut.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

Implement the migration for FIP0097
4 participants