-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration for transient data for nv25 #340
Conversation
This reverts commit 994d422.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #340 +/- ##
==========================================
- Coverage 3.39% 3.39% -0.01%
==========================================
Files 662 663 +1
Lines 177834 178012 +178
==========================================
Hits 6041 6041
- Misses 169944 170122 +178
Partials 1849 1849
|
@snissn looks like the branch is a bit out-of-date with the base branch, do you mind updating it with the latest changes? |
@snissn I went back to the FIP to cross-check but realised we never got the finer details put into that because it was mostly fleshed out in builtin-actors. I made an issue in the FIPs repo to get those filled in, it should be fairly simple to do and I made a proposed list as a starter: filecoin-project/FIPs#1110 |
functionally this is 👌 , just some minor non-functional nits left in comments |
Co-authored-by: Rod Vagg <rod@vagg.org>
Co-authored-by: Rod Vagg <rod@vagg.org>
Co-authored-by: Rod Vagg <rod@vagg.org>
Co-authored-by: Rod Vagg <rod@vagg.org>
…ect/go-state-types into mikers/transient_data_nv16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lovely
thanks @rvagg !! |
Thanks for merging @rjan90 !! |
@snissn I´m in the process of cutting a release here: #342, will mention it in your PR here filecoin-project/lotus#12849 once it is cut. |
No description provided.