Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEVM: update types #147

Merged
merged 5 commits into from
Jan 14, 2023
Merged

FEVM: update types #147

merged 5 commits into from
Jan 14, 2023

Conversation

Stebalien
Copy link
Member

No description provided.

@Stebalien
Copy link
Member Author

I've also audited feat/nv18-fevm in lotus and fixed the one case where we hard-coded the method number.

@Stebalien
Copy link
Member Author

Blocked on an actors release.

* add CreateExternal to eam

* use CborBytes instead of CreateExternalParams

* Update builtin/v10/eam/eam_types.go

Co-authored-by: Steven Allen <steven@stebalien.com>

* Update builtin/v10/eam/methods.go

Co-authored-by: Steven Allen <steven@stebalien.com>

* add CreateExternal to eam method list

Co-authored-by: Steven Allen <steven@stebalien.com>
@arajasek arajasek marked this pull request as ready for review January 14, 2023 01:31
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One copypasta nit

builtin/v10/evm/methods.go Outdated Show resolved Hide resolved
@arajasek arajasek merged commit 5f2a83a into master Jan 14, 2023
@arajasek arajasek deleted the feat/fevm-update branch January 14, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants