Skip to content

Market migration: Correctly migrate deal states #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2022

Conversation

arajasek
Copy link
Contributor

Quoting the FIP ,

Add the pending allocation mapping to market state, and claim ID field to deal states (all 0)

The second half of this direction (set claim ID field of deal states to 0) was missing. This PR adds the necessary operation.

Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One slight concern about perf, do we know how long it takes on mainnet with its 13M deals?

SectorStartEpoch: dealState8.SectorStartEpoch,
LastUpdatedEpoch: dealState8.LastUpdatedEpoch,
SlashEpoch: dealState8.SlashEpoch,
VerifiedClaim: 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: use #93

@ZenGround0
Copy link
Contributor

One slight concern about perf, do we know how long it takes on mainnet with its 13M deals?

AMT diffing used for sectors AMT should also help here

@ZenGround0 ZenGround0 merged commit 79443b5 into master Oct 21, 2022
@ZenGround0 ZenGround0 deleted the asr/market-migration-fix branch October 21, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants