Skip to content

Conversation

@dirkmc
Copy link
Contributor

@dirkmc dirkmc commented May 9, 2022

Ensure that the "ready" event is only fired after the start() method returns

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2022

Codecov Report

❌ Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.67%. Comparing base (70dbd2f) to head (a9652b0).
⚠️ Report is 67 commits behind head on master.

Files with missing lines Patch % Lines
storagemarket/impl/provider.go 37.50% 4 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #708      +/-   ##
==========================================
+ Coverage   58.60%   58.67%   +0.08%     
==========================================
  Files          64       64              
  Lines        5362     5398      +36     
==========================================
+ Hits         3142     3167      +25     
- Misses       1882     1886       +4     
- Partials      338      345       +7     
Files with missing lines Coverage Δ
storagemarket/impl/provider.go 26.63% <37.50%> (+3.74%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dirkmc dirkmc merged commit a088d71 into master May 9, 2022
@dirkmc dirkmc deleted the fix/provider-ready branch May 9, 2022 11:14
@dirkmc dirkmc mentioned this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants