Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/change prefixes 256 #257

Merged
merged 4 commits into from
May 18, 2020
Merged

Feat/change prefixes 256 #257

merged 4 commits into from
May 18, 2020

Conversation

shannonwells
Copy link
Contributor

@shannonwells shannonwells commented May 18, 2020

problem

We shouldn't be specifying the root namespace, rather give it a prefix only and allow nodes to add their own, otherwise attach to root.
Part of #256

solution

delete text specifying base namespace

@codecov-io
Copy link

codecov-io commented May 18, 2020

Codecov Report

Merging #257 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
+ Coverage   64.91%   64.97%   +0.07%     
==========================================
  Files          39       39              
  Lines        2288     2272      -16     
==========================================
- Hits         1485     1476       -9     
+ Misses        685      680       -5     
+ Partials      118      116       -2     
Impacted Files Coverage Δ
piecestore/piecestore.go 82.76% <ø> (ø)
retrievalmarket/impl/client.go 67.89% <ø> (ø)
retrievalmarket/impl/provider.go 70.91% <ø> (ø)
storagemarket/impl/provider.go 5.56% <ø> (ø)
retrievalmarket/discovery/local.go 60.98% <100.00%> (ø)
retrievalmarket/impl/blockio/traverser.go 72.23% <0.00%> (+3.34%) ⬆️
filestore/file.go 100.00% <0.00%> (+23.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 306cf1c...07ea8f6. Read the comment docs.

Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry small changes requested -- unless there are multiple keys needed there should be no namespace wrap at all.

retrievalmarket/impl/provider.go Outdated Show resolved Hide resolved
retrievalmarket/impl/client.go Outdated Show resolved Hide resolved
retrievalmarket/discovery/local.go Show resolved Hide resolved
@shannonwells shannonwells marked this pull request as ready for review May 18, 2020 18:24
@shannonwells shannonwells merged commit 950d428 into master May 18, 2020
@shannonwells shannonwells deleted the feat/change-prefixes-256 branch May 18, 2020 21:41
@dirkmc dirkmc mentioned this pull request Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants