-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/change prefixes 256 #257
Conversation
Codecov Report
@@ Coverage Diff @@
## master #257 +/- ##
==========================================
+ Coverage 64.91% 64.97% +0.07%
==========================================
Files 39 39
Lines 2288 2272 -16
==========================================
- Hits 1485 1476 -9
+ Misses 685 680 -5
+ Partials 118 116 -2
Continue to review full report at Codecov.
|
bc46300
to
07ea8f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry small changes requested -- unless there are multiple keys needed there should be no namespace wrap at all.
problem
We shouldn't be specifying the root namespace, rather give it a prefix only and allow nodes to add their own, otherwise attach to root.
Part of #256
solution
delete text specifying base namespace