Skip to content

fix: data-set command adjustments #66

@SgtPooki

Description

@SgtPooki

A couple of quick comments:

  1. It may just be me (and I'm certainly not up on modern command line conventions), but I actually like have to be explicit about with -ls rather than it just being implied just so it's more self documenting when someone looks at commands.
  2. ls I think is more of a subcommand than an option, so I'm wondering if this should read as filecoin-pin data-set [optionalDataSetId] ls. (but I realize the original issue said --ls so I may be off here)
  3. "Root CID" → "IPFS Root CID" to be consistent with the meta and drive home what this "root CID" is?
  4. I assume we'll add piece size in future once we can get it. That would be an open remaining item for Add data-set subcommand with --ls #7

Originally posted by @BigLep in #50 (comment)

Metadata

Metadata

Assignees

Labels

team/filecoin-pin"Filecoin Pin" project is a stakeholder for this work.team/fs-wgFOC working group is a stakeholder for this work, and thus wants to track it on their project board.

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions