Skip to content

chore: release Filecoin-FFI v1.32.0 #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Mar 27, 2025

  • Bumps Filecoin-FFI version to v1.32.0
  • Updates GST to v0.16.0.
    • I forgot to update to the latest GST release in this PR which shipped the v1.32.0-rc3 FFI release: chore: release v1.32.0-rc3 #520. So just want to sanity check that it should be fine to update this for the final release?

rjan90 added 2 commits March 27, 2025 09:39
chore: update GST to v0.16.0
chore: bump version to v1.32.0
@rjan90 rjan90 requested review from masih, Stebalien and rvagg March 27, 2025 08:46
@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Mar 27, 2025
Copy link

Suggested version: 1.32.0

Comparing to: v1.32.0-rc3 (diff)

Changes in configuration file(s):

(empty)

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to master. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

@@ -1,3 +1,3 @@
{
"version": "v1.32.0-rc3"
Copy link
Member

@masih masih Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocker/A small footnote here: I think the way releaser workflow works is that it doesn't include the PR that bumps the version number in the release notes of the release being made. This is because, it creates a draft release before the version bump is merged.

This behaviour is fine when the PR only bumps the version. But this PR does more: it also upgrades dependencies and as a consequence bumps go version.

If you'd like this change to appear in the release note: either separate the PRs, or manually update the generated release note to state this.

I personally, opt in for separate PRs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that is correct. I will separate the PRs

@github-project-automation github-project-automation bot moved this from 📌 Triage to ✔️ Approved by reviewer in FilOz Mar 27, 2025
@rjan90 rjan90 closed this Mar 27, 2025
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

2 participants