fix: FileMount should use url Path instead of Host
#157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, as you say we haven't come across this issue because we use a specific mount type |
Wondertan
reviewed
Apr 13, 2023
mount/file.go
Outdated
Comment on lines
47
to
48
| if u.Path == "" { | ||
| return fmt.Errorf("invalid host") |
distractedm1nd
force-pushed
the
filemount-path
branch
from
023f2ee to
c9e4b71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encountered a bug recently after switching from
FSMounttoFileMount.The root cause of the problem was the usage of the
Hostfield ofurl.URLto store the file path. This led to incorrect URL encoding, which caused the application to fail when trying to recover the state of shards.Should we add backwards compatibility to the
Deserializemethod so that mounts previouslySerialized()usingHostwill be loaded correctly?