Skip to content

Conversation

@dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Sep 16, 2022

Changes to the index-backed blockstore:

  1. In testing we found that blockstore.Get often fails because the block cannot be retrieved from the remote store. It is very unlikely to fail because of a corrupted index. So this PR simply returns an error immediately if an operation on the blockstore returns an error (instead of trying to re-acquire the blockstore).
  2. We also found that multiple concurrent calls to AcquireShard will call mount.Fetch once each. So this PR adds a sync.Once to synchronize between concurrent calls.

@dirkmc dirkmc changed the title feat: index-backed blockstore - synchronize acquires index-backed blockstore - synchronize acquires Sep 16, 2022
@dirkmc dirkmc merged commit 173a32a into feat/blockstore Sep 19, 2022
@dirkmc dirkmc deleted the feat/ibs-acquire-sync branch September 19, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants