Feature/fip 0027 market label #670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexey Chernyshov <alexey.n.chernyshov@gmail.com>
Signed-off-by: Alexey Chernyshov <alexey.n.chernyshov@gmail.com>
# Conflicts: # core/node/main/main.cpp
| @@ -119,7 +59,7 @@ namespace fc::vm::actor::builtin::types::market { | |||
| CBOR_TUPLE(DealState, sector_start_epoch, last_updated_epoch, slash_epoch) | |||
|
|
|||
| struct ClientDealProposal { | |||
| DealProposal proposal; | |||
| Universal<DealProposal> proposal; | |||
There was a problem hiding this comment.
proposal is ptr now and default copy assigment of ClientDealProposal is a shallow copy.
Please, take a look.
There was a problem hiding this comment.
If you need a full copy, please write copy constructor and operator for ClientDealProposal where call Universal::copy
Codecov Report
@@ Coverage Diff @@
## master #670 +/- ##
==========================================
+ Coverage 44.60% 44.64% +0.04%
==========================================
Files 753 755 +2
Lines 34345 34388 +43
Branches 19215 19232 +17
==========================================
+ Hits 15319 15354 +35
+ Misses 14540 14537 -3
- Partials 4486 4497 +11
|
turuslan
reviewed
Apr 27, 2022
turuslan
reviewed
Apr 27, 2022
turuslan
reviewed
Apr 27, 2022
wer1st
reviewed
Apr 28, 2022
core/vm/actor/builtin/types/market/deal_info_manager/deal_info_manager.hpp
Outdated
Show resolved
Hide resolved
turuslan
approved these changes
Apr 28, 2022
wer1st
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
FIP-0027 - Label encoding for market actors v8
Benefits
Possible Drawbacks
Usage Examples or Tests [optional]
Alternate Designs [optional]
Actors v8 to be implemented.