Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix u256 encoding #828

Merged
merged 1 commit into from
Nov 11, 2022
Merged

fix u256 encoding #828

merged 1 commit into from
Nov 11, 2022

Conversation

Stebalien
Copy link
Member

Always encode to a big-endian byte array.

fixes filecoin-project/ref-fvm#912

@Stebalien
fix u256 encoding
fa2d688 
Always encode to a big-endian byte array.

fixes filecoin-project/ref-fvm#912
@Stebalien Stebalien requested a review from vyzo November 10, 2022 20:52
raulk
raulk approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Stebalien Stebalien merged commit a56108c into next Nov 11, 2022
@Stebalien Stebalien deleted the fix/u256-encoding branch November 11, 2022 00:13
@Stebalien
Copy link
Member Author

So... we were storing these as hex strings in the state-tree 😱

@raulk
Copy link
Member

raulk commented Nov 11, 2022

Well, that's some easy gas reduction then 🤦‍♂️

@Stebalien Stebalien mentioned this pull request Nov 11, 2022
Merged
@mriise
Copy link
Contributor

mriise commented Nov 11, 2022

ez 2x gas savings 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzo vyzo vyzo approved these changes

@raulk raulk raulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Stebalien @raulk @mriise @vyzo