market actor tests p8 #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LesnyRumcajs
force-pushed
the
market-actor-tests-p8
branch
from
0da2ee8 to
3c077ff
Compare
ZenGround0
approved these changes
May 5, 2022
| deal_ids[0] | ||
| } | ||
|
|
||
| pub fn generate_and_publish_verified_deal( |
Contributor
There was a problem hiding this comment.
name should include the fact that we are adding funds.
Contributor
Author
There was a problem hiding this comment.
It's basically a copy of the function above with the verified_deal setting. I'd say we should keep the name or rename the one above as well. What do you think @ZenGround0 ?
Contributor
There was a problem hiding this comment.
Ah my bad, keeping it this way is ok
LesnyRumcajs
force-pushed
the
market-actor-tests-p8
branch
from
3c077ff to
ae7b7ae
Compare
snissn
pushed a commit
to snissn/builtin-actors
that referenced
this pull request
Apr 11, 2025
* fip-0031: prepare for move to Last Call. * define manifest data type for FIP 0031 (filecoin-project#329) Co-authored-by: raulk <raul@protocol.ai> Co-authored-by: vyzo <vyzo@hackzen.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented tests from here
verify_deal_and_get_deal_weight_for_unverified_deal_proposalverify_deal_and_get_deal_weight_for_verified_deal_proposalverification_and_weights_for_verified_and_unverified_dealsfail_when_caller_is_not_a_storage_miner_actorfail_when_deal_proposal_is_not_foundfail_when_caller_is_not_the_providerfail_when_current_epoch_is_greater_than_proposal_start_epochfail_when_deal_end_epoch_is_greater_than_sector_expirationfail_when_the_same_deal_id_is_passed_multiple_times