Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multisig vesting unit tests #295

Merged
merged 4 commits into from
May 1, 2022
Merged

Multisig vesting unit tests #295

merged 4 commits into from
May 1, 2022

Conversation

ZenGround0
Copy link
Contributor

@ZenGround0 ZenGround0 commented Apr 29, 2022

  • TestVesting
    • TestVesting/happy_path_full_vesting
    • TestVesting/partial_vesting_propose_to_send_half_the_actor_balance_when_the_epoch_is_half_the_unlock_duration
    • TestVesting/propose_and_autoapprove_transaction_above_locked_amount_fails
    • TestVesting/fail_to_vest_more_than_locked_amount
    • TestVesting/avoid_truncating_division
    • TestVesting/sending_zero_ok_when_nothing_vested
    • TestVesting/sending_zero_ok_when_lockup_exceeds_balance

@ZenGround0 ZenGround0 changed the base branch from master to test/multisig-test-9 April 29, 2022 16:53
@ZenGround0 ZenGround0 marked this pull request as ready for review April 29, 2022 21:22
@ZenGround0 ZenGround0 requested review from raulk, lemmih and vyzo and removed request for raulk April 29, 2022 21:22
Copy link
Contributor

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; dont forget the debug leftover prints.

@@ -100,6 +100,7 @@ impl Actor {
if params.unlock_duration < 0 {
return Err(actor_error!(illegal_argument; "negative unlock duration disallowed"));
}
println!("unlock duration: {}", params.unlock_duration);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debug leftover?

@@ -196,6 +197,7 @@ impl Actor {
BS: Blockstore,
RT: Runtime<BS>,
{
println!("rt sees epoch: {}", rt.curr_epoch());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too.

Base automatically changed from test/multisig-test-9 to master May 1, 2022 15:25
@ZenGround0 ZenGround0 merged commit d42dd40 into master May 1, 2022
@ZenGround0 ZenGround0 deleted the test/multisig-test-10 branch May 1, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants