chore(power): add CurrentTotalPowerReturn serialization tests #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
added a commit
to filecoin-project/lotus
that referenced
this pull request
Sep 30, 2024
rvagg
added a commit
to filecoin-project/lotus
that referenced
this pull request
Oct 1, 2024
|
Now that #1557 has been merged. Should this be opened for review? |
rvagg
added a commit
to filecoin-project/lotus
that referenced
this pull request
Oct 1, 2024
plus a minor naming fix
rvagg
force-pushed
the
rvagg/CurrentTotalPowerReturn-ser
branch
from
3362f51
to
db28a77
Compare
|
yep, rebased on master so it's just one commit now, good to go 👍 |
|
Matches the tests in filecoin-project/go-state-types#314 btw |
ZenGround0
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus a minor naming fix I noticed while looking over #1557. The market actor copy of
CurrentTotalPowerReturnis namedCurrentTotalPowerReturnParams.This is on top of #1557, and I'll wait till that's merged before marking this ready for review.