Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove Option around SectorPreCommitInfoInner.unsealed_cid #1570

Merged
merged 3 commits into from
Jul 25, 2024
Merged

fix: remove Option around SectorPreCommitInfoInner.unsealed_cid #1570

merged 3 commits into from
Jul 25, 2024

Conversation

kamuik16
Copy link
Contributor

Closes #1507

kamuik16
kamuik16 commented Jul 18, 2024
View reviewed changes
actors/miner/src/lib.rs Outdated Show resolved Hide resolved
@kamuik16 kamuik16 requested a review from rvagg July 18, 2024 08:01
@kamuik16
Copy link
Contributor Author

Hey @rvagg! wen can we merge this?

@rvagg rvagg added this pull request to the merge queue Jul 25, 2024
@rvagg
Copy link
Member

rvagg commented Jul 25, 2024

👍 I was hoping @anorth would pass an eye over this but I think it's good to go

Merged via the queue into filecoin-project:master with commit 82d02e5 Jul 25, 2024
10 checks passed
@kamuik16 kamuik16 deleted the kamui/1507 branch July 25, 2024 08:23
anorth
anorth reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@anorth anorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

actors/miner/src/lib.rs
Comment on lines 1654 to 1655
// Presence of unsealed CID is checked in the preconditions.
// It must always be specified from nv22 onwards.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is redundant now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anorth anorth anorth left review comments

@rvagg rvagg rvagg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Option around SectorPreCommitInfoInner.unsealed_cid
3 participants
@kamuik16 @rvagg @anorth