Move reward logic from fvm_shared to the shared runtime #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
commented
Feb 9, 2024
| }; | ||
| use super::*; | ||
|
|
||
| const ERR_BOUND: u64 = 350; |
There was a problem hiding this comment.
Tests moved from the tests/ directory so we can access private functions.
rvagg
reviewed
Feb 9, 2024
rvagg
approved these changes
Feb 9, 2024
anorth
reviewed
Feb 12, 2024
| pub this_epoch_reward_smoothed: FilterEstimate, | ||
| #[serde(with = "bigint_ser")] | ||
| pub this_epoch_baseline_power: StoragePower, | ||
| } |
There was a problem hiding this comment.
To be consistent with our existing patterns elsewhere, this should move into the reward actor, and then be duplicated in the ext module of actors that call it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, I'm moving everything into
fil_actors_runtime::builtin::reward. But... maybe we should have a new crate?