Move some constants & types out of fvm_shared #1517
Conversation
Stebalien
changed the title
|
More to come, but this covers some of the easy stuff. |
actors/market/src/policy.rs
Outdated
| use num_traits::Zero; | ||
|
|
||
| pub mod detail { | ||
| /// Maximum length of a deal label. | ||
| pub const DEAL_MAX_LABEL_SIZE: usize = 256; | ||
| } | ||
|
|
||
| lazy_static! { | ||
| /// Total Filecoin available to the network. |
There was a problem hiding this comment.
Commentary: The assumed total filecoin. We should really make this a syscall.
There was a problem hiding this comment.
TBH, this constant should just go away. It's used to specify collateral bounds, which is kind of unnecessary IMO (although I guess the idea is to limit the size of state?).
| use fvm_shared::clock::EPOCH_DURATION_SECONDS; | ||
| pub use fvm_shared::BLOCKS_PER_EPOCH as EXPECTED_LEADERS_PER_EPOCH; | ||
|
|
||
| pub const EPOCH_DURATION_SECONDS: i64 = 30; |
There was a problem hiding this comment.
Commentary: again assumed duration, but isn't something that gets defined by the actors.
There was a problem hiding this comment.
Yes, but changing this would require a massive migration so I think it's OK if the actors assume a specific duration. But I'll comment on that.
Stebalien
force-pushed
the
steb/reduce-shared
branch
from
07815ae
to
e0f95e1
Compare
Stebalien
force-pushed
the
steb/reduce-shared
branch
from
e0f95e1
to
7ca2b49
Compare
|
I've removed the type aliases and added a bunch of comments. |
Specifically:
MAX_SECTOR_NUMBERSpacetimeSectorQualityTOTAL_FILECOINEPOCH_DURATION_SECONDSBLOCKS_PER_EPOCH