Swallow deal termination error in cron #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1125 +/- ##
==========================================
+ Coverage 88.33% 88.42% +0.08%
==========================================
Files 103 103
Lines 20409 20417 +8
==========================================
+ Hits 18029 18054 +25
+ Misses 2380 2363 -17
|
Stebalien
reviewed
Jan 30, 2023
anorth
reviewed
Jan 31, 2023
ZenGround0
force-pushed
the
fix/remove-cron-contagion
branch
from
d8db36a
to
440e13d
Compare
arajasek
reviewed
Feb 9, 2023
anorth
approved these changes
Feb 9, 2023
actors/miner/src/lib.rs
Outdated
| ))?; | ||
| )); | ||
| // Intentionally swallow this error to prevent frozen market cron corruption from also freezing this miner cron. | ||
| // This is safe from a malicious caller perspective because this method's callstack should always originate with the trusted system caller. |
There was a problem hiding this comment.
Please update this comment; it's confusing, given the code below that denies the "should".
arajasek
approved these changes
Feb 9, 2023
There was a problem hiding this comment.
How hard would it be to add a unit test for this? I think most of the work would be setting up the state of having a sector with deals, then
- Call terminate sectors from the owner, mock the
ON_MINER_SECTORS_TERMINATE_METHODas failing, assert the call fails. - Call
on_deferred_cron_event/handle_proving_deadlinefrom the syst,m mock theON_MINER_SECTORS_TERMINATE_METHODas failing, assert the call succeeds?
|
I did the bad thing of merging without test because otherwise I don't think this will make it into code freeze tomorrow and introducing without test is less risky than not introducing at all IMO. Follow up issue #1194 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today if market cron freezes over in case of programmer error then any miner actors making use of cron to terminate sectors will also freeze. We should prefer to not do this to make frozen cron easier to recover and less disruptive. We don't gain much from this. Any recovery of frozen cron is going to need a migration and that migration should be able to filter out deals that have terminated since market cron froze. Frozen cron from programmer error isn't esoteric: this is exactly the cause of calibration reset last year. With FVM approaching and new classes of exploits becoming possible it makes sense to do this hardening.