Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM: Precompile test framework #1033

Merged
merged 7 commits into from
Jan 13, 2023
Merged

EVM: Precompile test framework #1033

merged 7 commits into from
Jan 13, 2023

Conversation

mriise
Copy link
Contributor

@mriise mriise commented Jan 13, 2023

This should make precompile tests easier to write, more comprehensive, and easier to understand

@mriise mriise mentioned this pull request Jan 13, 2023
Merged
@mriise mriise force-pushed the test/precompile-test-framework branch from 03feb36 to 9515fc1 Compare January 13, 2023 19:14
@mriise
Things:
d8f03cd 
- use full word for parameters, EVM has forced my hand by making it impossible to load _just a single byte_. asm should be easier to understand now
- Use full EthAddress so that we can test for invalid precompile address that are in precompile range
- Fix debug fmt implementation
@mriise mriise marked this pull request as ready for review January 13, 2023 20:10
@mriise mriise requested review from Stebalien and vyzo January 13, 2023 20:11
@mriise mriise linked an issue Jan 13, 2023 that may be closed by this pull request
EVM Precompile Test: get_actor_type filecoin-project/ref-fvm#1392
Closed
vyzo
vyzo approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all looks fine to me; i am sure steven would find some nits, but it is fine for my claws.

@mriise
Copy link
Contributor Author

mriise commented Jan 13, 2023

@Stebalien merging to get this landed, If you have any nits I can fix in a follow up. Remaining tests for call_actor are being blocked by this.

@mriise mriise enabled auto-merge (squash) January 13, 2023 21:50
@mriise mriise merged commit 672d771 into next Jan 13, 2023
@mriise mriise deleted the test/precompile-test-framework branch January 13, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzo vyzo vyzo approved these changes

@Stebalien Stebalien Awaiting requested review from Stebalien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EVM Precompile Test: get_actor_type
2 participants
@mriise @vyzo