EVM: return just the bytecode hash #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we returned a multihash. However, this got serialized as a map. Now, we just return the raw digest encoded as 32 bytes.
We've shaved quite a few bytes off by correctly serializing this.
Stebalien
force-pushed
the
steb/bytecode-hash
branch
from
1126159
to
712918b
Compare
|
Ignore the second commit, that's just updating the storage sizes. |
We need to return the digest, not the encoded multihash. This only affects the tests.
mriise
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we returned a multihash. However, this got serialized as a map.
Now, we just return the raw digest encoded as 32 bytes.