Skip to content

experiment: simplified load balancer #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 13 commits into from
Closed

experiment: simplified load balancer #801

wants to merge 13 commits into from

Conversation

@hannahhoward
Copy link
Collaborator

@hannahhoward hannahhoward commented Sep 13, 2022 •
edited
Loading

Goals

See how much simpler we can make the load balancer by removing the routing protocol as well as forwarding responses for inbound forwarding requests

Implementation

  • Remove the routing protocol, instead relying on a set peer config. (map of peer ID -> list of protocol IDs)
    • On peer connect, if peer is service node in the peer config, start listening on peers list of protocols, making the route "active"
    • On peer disconnect, if peer is service node in the peer config, stop listening on peers list of protocols
    • Makes code for both libp2p load balancer and service node much simpler, particularly service node (overall this PR has net 500 less LoC, which includes most complicated concurrency stuff - and that's without updatings tests, which will get shorter)
  • Also remove forwarding response for inbound requests
    • not sure how big a win this really is -- just a few deletions as a result

hannahhoward and others added 13 commits August 24, 2022 16:20
@hannahhoward @dirkmc
feat(booster-bitswap): booster bitswap MVP untested
115cda5
@hannahhoward @dirkmc
refactor(booster-bitswap): use API for fetching blocks
05f50e6
@hannahhoward @dirkmc
fix(deps): update deps to compile
b943a2b
@hannahhoward @dirkmc
feat(booster-bitswap): makefile & fixes
150b0ea 
add commands to build booster-bitswap, and very a round tripped successful fetch from
booster-bitswap
@dirkmc
refactor: clean up unused vars etc
6c15199
@dirkmc
fix: booster-bitsawp - check error when creating libp2p key
09e6313
@hannahhoward
refactor(node): avoid FreeAndUnsealed method
9148111
@hannahhoward
feat(loadbalancer): add message types
7504bee
@hannahhoward
feat(messages): add utility functions
589dfcf
@hannahhoward
feat(loadbalancer): initial load balancer impl
bb53483 
implementation of the load balancer node itself
@hannahhoward
feat(loadbalancer): add service node
72a97e0 
implements code for running a service node
@hannahhoward
feat(loadbalancer): integrate into boost and booster-bitswap
69beb47
@hannahhoward
refactor(loadbalancer): remove routing protocol
e0130b4 
remove the routing protocol, instead relying on a set config. also remove forwarding response for
inbound requests
@hannahhoward hannahhoward requested a review from dirkmc September 13, 2022 22:47
dirkmc
dirkmc approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks like a good simplification 👍

@hannahhoward hannahhoward force-pushed the feat/libp2p-loadbalancer branch from c2a6247 to a7d2b67 Compare September 16, 2022 00:00
@hannahhoward hannahhoward mentioned this pull request Sep 16, 2022
Merged
@nonsense nonsense deleted the feat/libp2p-loadbalancer-simplified branch January 17, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dirkmc dirkmc dirkmc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hannahhoward @dirkmc