fix dummydeal to wait for actual deal publish #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsense
force-pushed
the
nonsense/add-secb
branch
2 times, most recently
from
e5c6a5a to
86e2067
Compare
nonsense
force-pushed
the
nonsense/add-secb
branch
2 times, most recently
from
2bd10b4 to
1886e56
Compare
nonsense
force-pushed
the
nonsense/add-secb
branch
from
1886e56 to
29b6bd8
Compare
nonsense
commented
Nov 25, 2021
| @@ -17,6 +17,7 @@ const DefaultMaxTraversalLinks = 2 << 29 | |||
| func CommP(ctx context.Context, bs bstore.Blockstore, root cid.Cid) (cid.Cid, abi.UnpaddedPieceSize, error) { | |||
| // do a CARv1 traversal with the DFS selector. | |||
| sc := car.NewSelectiveCar(ctx, bs, []car.Dag{{Root: root, Selector: shared.AllSelector()}}, car.MaxTraversalLinks(DefaultMaxTraversalLinks)) | |||
| //sc := car.NewSelectiveCar(ctx, bs, []car.Dag{{Root: root, Selector: selectorparse.CommonSelector_ExploreAllRecursively}}, car.MaxTraversalLinks(DefaultMaxTraversalLinks)) | |||
There was a problem hiding this comment.
I am not sure if our code is working for CARv1 right now, so leaving this here, until we fix it. Actually util.CommP will probably go away altogether.
nonsense
commented
Nov 25, 2021
Comment on lines
+278
to
+289
| //head, err := n.ChainHead(ctx) | ||
| //if err != nil { | ||
| //return nil, xerrors.Errorf("WaitForPublishDeals failed to get chain head: %w", err) | ||
| //} | ||
|
|
||
| res, err := n.scMgr.dealInfo.GetCurrentDealInfo(ctx, head.Key().Bytes(), (*market.DealProposal)(&proposal), publishCid) | ||
| if err != nil { | ||
| return nil, xerrors.Errorf("WaitForPublishDeals getting deal info errored: %w", err) | ||
| } | ||
| //res, err := n.scMgr.dealInfo.GetCurrentDealInfo(ctx, head.Key().Bytes(), (*market.DealProposal)(&proposal), publishCid) | ||
| //if err != nil { | ||
| //return nil, xerrors.Errorf("WaitForPublishDeals getting deal info errored: %w", err) | ||
| //} | ||
|
|
||
| return &storagemarket.PublishDealsWaitResult{DealID: res.DealID, FinalCid: receipt.Message}, nil | ||
| return &storagemarket.PublishDealsWaitResult{DealID: abi.DealID(4), FinalCid: receipt.Message}, nil | ||
| //return &storagemarket.PublishDealsWaitResult{DealID: res.DealID, FinalCid: receipt.Message}, nil |
There was a problem hiding this comment.
We need to be monitoring the chain for the proposalCID, and get the dealID, when the deal is published. For now we have this hacked, and this will only work fork the first deal.
dirkmc
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is:
PublishedConfirmed- at this stage the deal is successfully transferred to a sector on the miner side.--tags=debugbuild flag when running integration testssectorblocks.SectorBlockswhen creating the storage providern.scMgras it isniland we want to refactor theAdapterin any case, rather than fix it.TODO:
boost dummydealcmdline tool to create a random CARv2 file and transfer it toboost