Skip to content

fix dummy deal test with transport #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 23, 2021
Merged

fix dummy deal test with transport #72

merged 11 commits into from
Nov 23, 2021

Conversation

nonsense
Copy link
Member

@nonsense nonsense commented Nov 22, 2021 •
edited
Loading

This PR is fixing the Dummydeal API endpoint to actually negotiate a deal with a Lotus miner, and get that storage deal to a Published state.

TODO (follow-up):

  • figure out why ActorAddress() is return f-type addrs and not t-type.
  • confirm provider_loop.go changes, so that we don't introduce regressions due to merge conflicts with main.

@nonsense nonsense changed the base branch from fix/dummy-deal-test to main November 23, 2021 12:28
@nonsense nonsense changed the title add setControlAddresses fix dummy deal test with transport Nov 23, 2021
@nonsense nonsense marked this pull request as ready for review November 23, 2021 13:15
@nonsense nonsense merged commit bb66296 into main Nov 23, 2021
@dirkmc dirkmc deleted the nonsense/fix/dummy-deal-test branch November 23, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarshkshah1992 aarshkshah1992 Awaiting requested review from aarshkshah1992

1 more reviewer

@dirkmc dirkmc dirkmc approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nonsense @dirkmc