Add optional signature on query-ask v2 #691
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahhoward
force-pushed
the
feat/retrieval-query-ask-v2-signed
branch
from
97f5a5c to
cf87302
Compare
hannahhoward
force-pushed
the
feat/retrieval-query-ask-v2
branch
from
eabe821 to
62e8a24
Compare
hannahhoward
force-pushed
the
feat/retrieval-query-ask-v2-signed
branch
from
cf87302 to
8c01c5e
Compare
hannahhoward
force-pushed
the
feat/retrieval-query-ask-v2-signed
branch
from
8c01c5e to
210e1f0
Compare
|
👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
@s0nik42 suggest a number of very smart improvements to the retrieval and storage protocols in #666. We probably need to think these through, but since we are in the middle of redoing the QueryAsk protocol for retrievals anyway, I made this follow on PR to #671 that adds support for optional signature verification.
Implementation