Skip to content

booster-http #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 17, 2022
Merged

booster-http #574

merged 7 commits into from
Jun 17, 2022

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Jun 7, 2022 •
edited
Loading

Builds off of #495 to run a separate http service

TODO:

  • Better config handling
  • Is it ok to use an in-memory repo?
  • Better access logging
  • Better error messages when things go wrong
$ ./booster-http run --api-boost=$BOOST_API_INFO --api-fullnode=$FULLNODE_API_INFO --api-sealer=$MINER_API_INFO
2022-06-14T14:09:26.556+0200	INFO	booster	booster-http/run.go:196	Using boost API at ws://127.0.0.1:1288/rpc/v0
2022-06-14T14:09:26.557+0200	INFO	booster	booster-http/run.go:213	Using full node API at ws://127.0.0.1:1234/rpc/v1
2022-06-14T14:09:26.558+0200	INFO	booster	booster-http/run.go:239	Using sealing API at ws://127.0.0.1:2345/rpc/v0
2022-06-14T14:09:26.562+0200	INFO	booster	booster-http/run.go:102	Miner address: f01000
2022-06-14T14:09:26.564+0200	INFO	booster	booster-http/run.go:132	Starting booster-http node on port 7777 with base path ''
2022-06-14T14:09:29.627+0200	200	GET /piece/baga6ea4seaqgbkvk6apsnfbtvnbjabpu4tsv6ns45c36452fdhkqxznt3vlnedq.car
2022-06-14T14:09:29.630+0200	DONE	GET /piece/baga6ea4seaqgbkvk6apsnfbtvnbjabpu4tsv6ns45c36452fdhkqxznt3vlnedq.car
2022-06-14T14:09:29.630+0200 - 2022-06-14T14:09:29.627+0200: 2.753664ms / 1,101 bytes transferred

@dirkmc dirkmc changed the title feat: booster-http booster-http Jun 7, 2022
@dirkmc dirkmc force-pushed the feat/booster-http branch 2 times, most recently from 57c3fbe to 147ba60 Compare June 10, 2022 15:05
willscott
willscott reviewed Jun 10, 2022
View reviewed changes
@dirkmc dirkmc mentioned this pull request Jun 14, 2022
Closed
@dirkmc dirkmc force-pushed the feat/booster-http branch 2 times, most recently from 83942cb to 297fbbd Compare June 14, 2022 12:28
@dirkmc dirkmc marked this pull request as ready for review June 14, 2022 13:11
jacobheun
jacobheun reviewed Jun 16, 2022
View reviewed changes
cmd/booster-http/server.go

// Just get the content of the first piece returned (if the client wants a
// different piece they can just call the /piece endpoint)
pieceCid := pieces[0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I reading this code right in that this isn't actually restricted to the payload CID? So I could provide any indexed multihash and get back some CAR that contains it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep that's right 👍

@dirkmc dirkmc force-pushed the feat/booster-http branch from 93a4ddd to b6f34fb Compare June 17, 2022 06:08
@dirkmc dirkmc merged commit 4e3c3f4 into main Jun 17, 2022
@dirkmc dirkmc deleted the feat/booster-http branch June 17, 2022 06:13
@jacobheun jacobheun mentioned this pull request Jul 7, 2022
Open
@jacobheun jacobheun mentioned this pull request Aug 22, 2022
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willscott willscott willscott left review comments

@jacobheun jacobheun jacobheun left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dirkmc @willscott @jacobheun