Skip to content

refactor: move deal handling code into one place #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 17, 2022
Merged

refactor: move deal handling code into one place #525

merged 2 commits into from
May 17, 2022

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented May 13, 2022

No description provided.

@dirkmc dirkmc force-pushed the refactor/deal-handler branch 2 times, most recently from 09b054c to a96c213 Compare May 13, 2022 08:18
@dirkmc dirkmc force-pushed the refactor/deal-handler branch from a96c213 to 1e98b2c Compare May 13, 2022 08:45
@dirkmc dirkmc mentioned this pull request May 13, 2022
Merged
5 tasks
@dirkmc dirkmc marked this pull request as ready for review May 16, 2022 14:56
@nonsense nonsense self-requested a review May 16, 2022 16:33
nonsense
nonsense approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@nonsense nonsense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! i think this is simpler than what we have right now.

@dirkmc
Retry deal (#521)
988245f 
* feat: retry deal

* refactor: rename errors for clarity

* Deal retry web UI (#526)

* feat: deal retry web ui

* fix: allow manual restart of deals in 'auto' retry state

* fix: simplify fail deal error message

* refactor: move deal running state onto deal handler (#527)
@dirkmc dirkmc merged commit 6fc5042 into main May 17, 2022
@dirkmc dirkmc deleted the refactor/deal-handler branch May 17, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nonsense nonsense nonsense approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirkmc @nonsense