Skip to content

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Aug 20, 2025

Fixes HEAD request for trustless HTTP, including probe requests from IPFS gateway

Fixes HEAD request for trustless HTTP, including probe requests from
IPFS gateway
@rvagg
Copy link
Member Author

rvagg commented Aug 21, 2025

FYI I haven't figured out this breakage (yet), but I know the following:

  • It's causing EOF on reading certain blocks from the blockstore which propagates up to retrievals, that's the main failure
  • It's not because we upgraded to 1.24 (I think), the main branch also fails when running on 1.24
  • It's not frisbii, I can downgrade that all the way back and it still fails, plus this is in the blockstore so it's deeper than that
  • go-car/v2 seems like an obvious candidate, but it's only dependencies and Go version that changed between the two versions
  • It's not go-varint, I did update that recently with an optimisation in UvarintSize but I can downgrade it here and it still fails

My guess is that it could be related to boxo; I just don't know how. It could also be one of the block or ipld interface libraries, but I also don't know how.

rvagg added a commit to filecoin-project/lotus that referenced this pull request Sep 4, 2025
- Keep PR #12884's buffer overflow fix (clamp to buffer size)
- Add graceful handling of io.ErrUnexpectedEOF for partial pieces
- Fixes boost EOF errors when reading 7MB deals in 8MB sectors
  Ref: filecoin-project/boost#2020
- Add test for partial piece reading edge case
rvagg added a commit to filecoin-project/lotus that referenced this pull request Sep 4, 2025
Ref: https://filecoinproject.slack.com/archives/CP50PPW2X/p1756905471593619
Ref: filecoin-project/boost#2020

- Keep PR #12884's buffer overflow fix (clamp to buffer size)
- Add graceful handling of io.ErrUnexpectedEOF for partial pieces
- Fixes boost EOF errors when reading 7MB deals in 8MB sectors
- Add test for partial piece reading edge case
rvagg added a commit to filecoin-project/lotus that referenced this pull request Sep 5, 2025
…13306)

Ref: https://filecoinproject.slack.com/archives/CP50PPW2X/p1756905471593619
Ref: filecoin-project/boost#2020

- Keep PR #12884's buffer overflow fix (clamp to buffer size)
- Add graceful handling of io.ErrUnexpectedEOF for partial pieces
- Fixes boost EOF errors when reading 7MB deals in 8MB sectors
- Add test for partial piece reading edge case
BigLep pushed a commit to filecoin-project/lotus that referenced this pull request Sep 5, 2025
…13306)

Ref: https://filecoinproject.slack.com/archives/CP50PPW2X/p1756905471593619
Ref: filecoin-project/boost#2020

- Keep PR #12884's buffer overflow fix (clamp to buffer size)
- Add graceful handling of io.ErrUnexpectedEOF for partial pieces
- Fixes boost EOF errors when reading 7MB deals in 8MB sectors
- Add test for partial piece reading edge case
TippyFlitsUK pushed a commit to filecoin-project/lotus that referenced this pull request Sep 5, 2025
…13306)

Ref: https://filecoinproject.slack.com/archives/CP50PPW2X/p1756905471593619
Ref: filecoin-project/boost#2020

- Keep PR #12884's buffer overflow fix (clamp to buffer size)
- Add graceful handling of io.ErrUnexpectedEOF for partial pieces
- Fixes boost EOF errors when reading 7MB deals in 8MB sectors
- Add test for partial piece reading edge case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant