Skip to content

Add monitoring alert UI element #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 14, 2023
Merged

Add monitoring alert UI element #1517

merged 9 commits into from
Jun 14, 2023

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Jun 13, 2023

Screenshot 2023-06-13 at 10 44 00 AM

@LexLuthr LexLuthr changed the base branch from nonsense/piece-store to feat/monitor-stuck-msgs June 13, 2023 09:06
@LexLuthr LexLuthr changed the base branch from feat/monitor-stuck-msgs to nonsense/piece-store June 13, 2023 09:09
@dirkmc dirkmc force-pushed the feat/monitoring-alert-ui branch from a5b12ea to a6792ec Compare June 13, 2023 09:20
@dirkmc dirkmc changed the base branch from nonsense/piece-store to main June 13, 2023 09:22
@LexLuthr LexLuthr marked this pull request as ready for review June 13, 2023 10:38
dirkmc
dirkmc commented Jun 13, 2023
View reviewed changes
@dirkmc
Copy link
Contributor Author

dirkmc commented Jun 13, 2023

@LexLuthr were you able to try this out in a devnet?
You can make the alert appear by setting the alert epochs to a lower number in config (eg 1) and then publishing a deal.
Before doing that though you may want to hard-code the value returned from the resolver to a number > 1 to make sure that part is working.

@LexLuthr
Copy link
Collaborator

@LexLuthr were you able to try this out in a devnet? You can make the alert appear by setting the alert epochs to a lower number in config (eg 1) and then publishing a deal. Before doing that though you may want to hard-code the value returned from the resolver to a number > 1 to make sure that part is working.

I am updating the JS query polling and setting a negative alert epochs to test this now.

LexLuthr added 2 commits June 13, 2023 18:32
@LexLuthr
Copy link
Collaborator

It is working on devnet

Screenshot 2023-06-13 at 7 48 04 PM

@LexLuthr
Copy link
Collaborator

I have also fixed the empty Gas Limit issue. It was a one line fix so it did not make sense to do a separate PR.

Screenshot 2023-06-13 at 11 19 45 PM

@dirkmc
Copy link
Contributor Author

dirkmc commented Jun 14, 2023

Looks great, nice work! 🙌
I opened the PR so I can't click the approve button, but LGTM 👍
Feel free to merge when ready.

@LexLuthr LexLuthr merged commit c9c08be into main Jun 14, 2023
@LexLuthr LexLuthr deleted the feat/monitoring-alert-ui branch June 14, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LexLuthr LexLuthr LexLuthr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirkmc @LexLuthr