Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIP-0083: add "client" to verifier-balance event #968

Merged

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Mar 20, 2024

Further to #964, this is a proposed change to FIP-0083 that we'd like to slip in to the current network upgrade in order to improve observability for certain observers of the network based on feedback we have received while trying to assist with nv22 integration.

The change here is simply to add a "client" field to the existing verifier-balance event emitted from the verified registry actor. This field will be null for cases where a verifier's allowance does not change as a result of allocation to a verified client, but will be the actor ID of the client where a client is involved.

Ultimately, in discussion, some of us have come to the conclusion that this event was not properly considered when originally implemented and does not allow for straightforward tracking of verifier allowances, and in its current form doesn't help connecting relationships and flows between verifiers and clients. Rather than attempting to augment or fix this event, we will likely propose a new FIP after this network upgrade to replace this event entirely with a new suite of events focused on datacap allowance and allocation flows to and from verifiers. e.g.

  • add-allowance - emitted when a verifier's allowance is set using AddVerifier, possibly including a delta and final balance since this method can be used to initialise, add or even decrease an allowance.
  • allocate-datacap - emitted when a verifier allocates datacap to a verified client, including the client (the "client" in this proposal), the amount allocated, and the final balance of the verifier's allowance.
  • remove-verifier - emitted when a verifier is removed from the verified registry, possibly including the final balance of the verifier's allowance.

Additional work could be done in the datacap actor to add observability to flows on the client side.

In the meantime, we believe that adding the field in this PR to the existing verifier-balance field will provide a lightweight but useful stopgap for the nv22 integration and other observers of the network.

Discussion thread specifically for this change is: #754 (comment)

TippyFlitsUK
TippyFlitsUK approved these changes Mar 20, 2024
@jennijuju
Copy link
Member

jennijuju commented Mar 20, 2024

Editor Review: Thank you for the detailed PR description. This is an enhancement for the proposed FIP to be useful for tooling builders and is a well contained change. Approved.

FIPS/fip-0083.md Outdated Show resolved Hide resolved
@aarshkshah1992
Copy link
Contributor

lgtm

@TippyFlitsUK TippyFlitsUK merged commit 8b0a604 into filecoin-project:master Mar 21, 2024
1 check passed
aarshkshah1992 added a commit that referenced this pull request Mar 21, 2024
@rvagg rvagg deleted the rvagg/0083-verifier-balance branch March 22, 2024 02:45
rvagg added a commit to rvagg/FIPs that referenced this pull request Apr 3, 2024
jennijuju pushed a commit that referenced this pull request Apr 4, 2024
"client" in verifier-balance was merge-resolved out

Closes: #971
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants