Skip to content

Conversation

klingtnet
Copy link
Contributor

It is github.com/filebrowser/caddy... and not
github.com/filebrowser/filebrowser/caddy... .

It is `github.com/filebrowser/caddy...` and not
`github.com/filebrowser/filebrowser/caddy...` .
@klingtnet
Copy link
Contributor Author

The caddy build still crashes, but now with this failure:

.go/src/github.com/filebrowser/filebrowser/lib/file.go:195:15: undefined: parser.ReadFrom
make: *** [Makefile:10: caddy] Error 2

which corresponds to the godoc where no ReadFrom can be found.

@klingtnet
Copy link
Contributor Author

The build.sh from this project fails with the same message:

# github.com/filebrowser/filebrowser/lib
../../.go/src/github.com/filebrowser/filebrowser/lib/file.go:195:15: undefined: parser.ReadFrom

@klingtnet
Copy link
Contributor Author

klingtnet commented Nov 20, 2018

Ok, there is already an issue filebrowser/filebrowser#554 regarding the build failure. You should think about using go modules to prevent this there's already an PR: filebrowser/filebrowser#496

@eine eine merged commit 5577baf into filebrowser:master Nov 20, 2018
@eine
Copy link
Contributor

eine commented Nov 20, 2018

Thanks @klingtnet! Precisely, usage of go modules is discussed in filebrowser/filebrowser#496.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants