Skip to content
This repository has been archived by the owner on Aug 4, 2020. It is now read-only.

Igal/python client 2 #322

Closed
wants to merge 2 commits into from
Closed

Igal/python client 2 #322

wants to merge 2 commits into from

Conversation

tsorya
Copy link
Collaborator

@tsorya tsorya commented Jul 1, 2020

No description provided.

@tsorya tsorya requested review from YuviGold and ronniel1 July 1, 2020 08:10
@filanov
Copy link
Owner

filanov commented Jul 1, 2020

Are all those files need to be part of the repo? if we need it just for the container shouldn't it be in git ignore?

@tsorya
Copy link
Collaborator Author

tsorya commented Jul 1, 2020

@filanov that's the problem. Right now they should. cause test-infra will install client from bm-inventory repo.
When we will make multistage working we will delete it and move to multistage.

@tsorya
Copy link
Collaborator Author

tsorya commented Jul 1, 2020

for multistage we will add client as part of bm-inventory image and use it in building test-infra.

@filanov
Copy link
Owner

filanov commented Jul 1, 2020

So why not make it an egg or something like this?

@tsorya
Copy link
Collaborator Author

tsorya commented Jul 1, 2020

to say the truth dunno how to make it work with egg. As i said we hope it will be temporary till we find a way to work with multistage in prow.
it was agreed with @ronniel1 to make it this way

@tsorya
Copy link
Collaborator Author

tsorya commented Jul 1, 2020

@filanov but if u know how to make it work with egg will be great to hear

@filanov
Copy link
Owner

filanov commented Jul 1, 2020

@filanov but if u know how to make it work with egg will be great to hear

Sadly i don't

@YuviGold
Copy link
Collaborator

YuviGold commented Jul 1, 2020

I am against adding 168 new files to the repo just for a patch.. Why the 1st PR was closed?

@tsorya
Copy link
Collaborator Author

tsorya commented Jul 1, 2020

@YuviGold 1st pr will not work in this case. So it is not relevant for now

@tsorya
Copy link
Collaborator Author

tsorya commented Jul 1, 2020

relevant change in test-infra openshift/assisted-test-infra#12

@filanov
Copy link
Owner

filanov commented Jul 1, 2020

@YuviGold do you know how to make it a single file?

@YuviGold YuviGold closed this Jul 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants