Fix: forget a closed action's cached schema when it is unmounted - #20361
Open
webard wants to merge 1 commit into
Open
Fix: forget a closed action's cached schema when it is unmounted#20361webard wants to merge 1 commit into
webard wants to merge 1 commit into
Conversation
Contributor
Author
|
I realize that the same fix can be achieved in userland with the However, if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
unmountAction()pops the action offmountedActions, but leaves its schema incachedSchemasunder
mountedActionSchema{nestingIndex}.getMountedActionSchema()reads that cache before itbuilds anything, so an action mounted at the same nesting index later in the same request is handed the schema of
the action that has just closed.
This causes actions to have their own header and footer, but someone else’s form. The bug appeared while testing the
modalClickThrough()method. It occurred when I opened one action and then, without closing the current one, opened another.Functional changes
composer cscommand.