Skip to content

Conversation

@Arne1303
Copy link

Description

Right now it is possible to check for extraAttributes on columns using

  • assertTableColumnHasExtraAttributes()
  • assertTableColumnDoesNotHaveExtraAttributes()

However, the same functionality does not exist when using extraImgAttributes on the ImageColumn. I added

  • assertTableColumnHasExtraImgAttributes()
  • assertTableColumnDoesNotHaveExtraImgAttributes()

to add that functionality.

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@github-project-automation github-project-automation bot moved this to Todo in Roadmap Jan 30, 2026
@danharrin danharrin added the enhancement New feature or request label Jan 30, 2026
@danharrin danharrin added this to the v4 milestone Jan 30, 2026
@danharrin
Copy link
Member

I'm not accepting new testing helpers like this, because then eventually we will end up with a testing helper for every single possible configuration method which is not practical.

Instead, I suggest using assertTableColumnExists() with a function to check if the column exists with the attributes that you specify

@danharrin danharrin closed this Jan 30, 2026
@github-project-automation github-project-automation bot moved this from Todo to Done in Roadmap Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants