Top align section header icon #19147
Open
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a sections contains both a heading and a description the icon was vertically centered instead of staying at the top. The example image in the documentation also represents the corrected behaviour: https://filamentphp.com/docs/4.x/schemas/sections#adding-an-icon-to-the-sections-header Signed-off-by: Lars Schröder <lars.schroeder@kielcoding.de>
Member
|
@larsbo I did review it, please see my comment above |
Author
|
@danharrin In my opinion the center alignment introduced with #16935 is less helpful than the top alignment. The only case that benefits from it is the one from the screenshot: 2 text rows + action button.
And the top alignment variant seems to be more consistent compared with other components like modals and notifications with a top aligned close icon. What do you think? |
Member
|
I agree that the icon should be top aligned, but I am not going to merge a PR that just introduces a separate issue. I think that the actions should be center aligned. |
Signed-off-by: Lars Schröder <lars.schroeder@kielcoding.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Top align section header icon.
Visual changes
If a sections contains both a heading and a description the icon was vertically centered instead of staying at the top.
The example image in the documentation also represents the corrected behaviour: https://filamentphp.com/docs/4.x/schemas/sections#adding-an-icon-to-the-sections-header
Functional changes
composer cscommand.