-
Notifications
You must be signed in to change notification settings - Fork 7
Issue #2407 - Update FileSaver.js dependency to the latest version
#2415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jhou-pro
wants to merge
83
commits into
3.0.0-SNAPSHOT
Choose a base branch
from
Issue-#2407
base: 3.0.0-SNAPSHOT
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continuing to move from old-style imports to rigid ES6-style imports, we need to support custom imports in IPre/PostActions for generated from Java actions. This will be required for FileSaverPostAction and likely will be used in other Pre/PostActions (e.g. OpenLinkPostAction). This commit contains support for main menu actions.
And placed to npm / Rollup infrastructure. Explicitly used unminified file.
Regenerated the tree.
…ing ES6-like file-saver dependency function instead of old, everywhere imported, file).
…indSavedPropertyPostActionSuccess/Error contexts.
…ed in required ReferenceHierarchyPreAction contexts.
…/ secondary actions).
'file-saver' dependency is now as a standard ES6 imported one and gets vulcanised into the main file depending if is actually needed.
Revulcanised to get rid of actually unused FileSaver checksums.
This reverts commit 07494c3.
…hout the need to import statements and composability.
FileSaver.js dependency to the latest version
…rate JS file. This also allows easier JavaScript editing through normal means and better future maintenance.
But still closed for usage outside PreActions / PostActions factory methods.
$ Conflicts: $ platform-web-resources/src/main/java/ua/com/fielden/platform/web/resources/webui/AbstractWebUiConfig.java $ platform-web-ui/src/main/web/ua/com/fielden/platform/web/app/tg-app-template.js
… 2.0.3 tg version
…g import in templates.
oleh-maikovych
approved these changes
Jul 18, 2025
| combinedImports.add(namedImport("TgReflector", "/app/tg-reflector")); | ||
| assertEquals(of(namedImport("TgReflector", "/app/tg-reflector", "TgReflector")), combinedImports); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like that this test is duplicate of the previous one.
…2407 $ Conflicts: $ platform-web-resources/src/main/java/ua/com/fielden/platform/web/resources/webui/AbstractWebUiConfig.java $ platform-web-resources/src/main/java/ua/com/fielden/platform/web/test/server/config/TgGeneratedEntityForTrippleDecAnalysisWebUiConfig.java $ platform-web-ui/src/main/java/ua/com/fielden/platform/web/centre/api/resultset/impl/FunctionalActionElement.java $ platform-web-ui/src/main/web/ua/com/fielden/platform/web/app/tg-app-template.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #2407
To be completed by the pull request creator
This section should be completed with reference to section Preparing PR of the Code and PR reviews wiki page.
Converted PR to draft while it is being prepared by tapping the "Convert to draft" link beneath the "Reviewers" section.
A self-review of all changes has been completed, and the changes are in sync with the issue requirements.
Changes to the requirements have been reflected in the issue description.
Any "leftovers" such as sysouts, printing of stack traces, and any other "temporary" code, have been removed.
Minor refactorings, such as renamings, extraction of constants, etc., have been addressed.
Developer documentation (e.g., comments, Javadoc), have been provided where required.
New Java tests have been written to cover the new functionality.
All existing and new Java tests pass successfully by running them with Maven.
All existing Web tests pass successfully.
Changes have been inspected for possible NPE situations, and the changes are sufficiently defensive.
The correct base branch has been selected for these changes to be merged into.
The latest changes from the base branch have already been merged into this feature branch (and tested).
Added a change overview to the issue description or as a wiki page, referenced in the issue description.
Some issue might be very descriptive and server in place of a wiki page.
In such cases consider adding label
Wiki liketo the issue.Changes subject to performance considerations have been evaluated, and tested against production-size data if applicable.
This pull request does contain significant changes, the section "Significant changes" below is completed and at least one Senior Software Engineer with the relevant area of expertise has been selected as reviewer.
The
In progresslabel has been removed from the issue.The
Pull requestlabel has been added to the issue.Made PR ready for review by tapping the "Ready for review" button below the list of commits on the PR page.
Significant changes
This pull request contains significant changes as defined in the wiki page.
Details are as follows:
FileSaver.jslibrary has been updated from1.xto2.0.5, comprising a major version update. The newly updated file saving support has been tested successfully against all three groups of browser engines (WebKit/JSC-Ubuntu GNOME Web aka EpiphanyandiOS Safari,Blink/V8-Ubuntu ChromeandAndroid Chrome,Gecko/SpiderMonkey-Ubuntu Firefox). It does also work on olderWindows Chrome Beta. Notable updates to the library are listed in a Changelog. No other updates were made since 2020, suggesting it is quite stable and works properly with all security-related browser tightening over the last years. All opened tabs are handled security-wise to avoid tabnapping and reverse-tabnapping.saveAsfunction is not available in awindowobject now. This is essentially a breaking change. However, only a rare occurence ofsaveAsfunction usage have been performed in end-applications (+HierarchyExportActiononly) -- non updated end-app will have a bug.Additional details
Additional breaking changes have been added to facilitate consistency across all code and to enforce further safer evolution of it. Otherwise, we would be left with some old way and new way and API users would follow what is easier / closer to their context. Actual existence of broken code in end-apps will be marked with [+].
PreActions / PostActionsfactory methods (constructors of existing implementations were made package-private).GuardCentreRegeneration[Post-]Actionto not beIPostAction, butIAction.getParentAndfunction in Entity Master contexts.TgReflectorin Entity Master / Centre contexts.bindSavedPropertypost-action to useIConvertableToPath.The following aspects were improved during implementation:
tg-app-template. It was not sufficient to generate imports there. We needed a way to reference imported functions inside dynamicnew Function(' ... some javascript code ... ')functions. It was implemented through passing all arguments into Function constructor and thenbind(...)actual imported function values.JsImportandCombinedJsImportswas added to every place, whereIPre/PostActions generate. Even to those places where such actions have no actual imports. This will encourage API user to always useimportStatements()where needed and, if added, to remain workable.fullcalendar and @fullcalendar/moment-timezonewere updated from6.1.15to6.1.17. This functionality was retested successfully. See the Changelog about bug fixes, that may be relevant for us.moment-timezonewas updated from0.5.47to0.5.48(very minor, only time-zone descriptions).RichTextdependencies are now as follows:dompurify 3.2.4 => 3.2.5-- Changelog has been reviewed and looks good (only bug fix).
prosemirror-commands 1.7.0 => 1.7.1prosemirror-model 1.25.0 => 1.25.1prosemirror-transform 1.10.3 => 1.10.4prosemirror-view 1.38.1 => 1.39.2-- Changelog has been reviewed and looks good (only bug fixes and one non-breaking feature).
This functionality was retested successfully.
event.waitUntilhas been employed everywhere in Service Worker where it was actually needed, including one missing place -- during activation. Even though it is unlikely that the absence of it caused problems to users, we should still be careful in keeping Service Worker alive before our custom actions complete asynchronously./resource update, which is handled by yet previous version of Service Worker. That's why clearing of redundant resources will not be performed on first release after these changes (but on the next one after the first). The decision to induce clearing on/resource update was made to ensure clearing on each release as soon as possible (but not more than once). Every client reload, including on some non-/contexts (e.g. on standalone centre), requires/resource update./resource is updated on each release, because it contains newly generated version in its title.Console settingsin right-top corner and uncheckSelected context onlyand checkPreserve logb) useDefault levelsin right-top corner (Info, Warnings and Errors).To be completed by the pull request reviewer
This section should be completed with reference to section Performing PR review of the Code and PR reviews wiki page.
The
In progresslabel has been added to the pull request in GitHub.The issue requirements have been read and understood (along with any relevant emails and/or Slack messages).
The correct base branch is specified, and that base branch is up-to-date in the local source.
The issue branch has been checked out locally, and had the base branch merged into it.
All automated tests pass successfully.
Ensure the implementation satisfies the functional requirements.
Ensure that code changes are secure and align with the established coding practices, including code formatting and naming conventions.
Ensure that code changes are documented and covered with automated tests as applicable.
Ensure that code changes are well-suited for informal reasoning.
Ensure that changes are documented for the end-user (a software engineer in the case of TG, or an application user in the case of TG-based applications).
If there are significant changes (described above), special attention has been paid to them.
Marked the task items in section "Significant changes" as completed to indicate that corresponding changes have been reviewed, improved if necessary, and approved.
The issue or issues addressed by the pull request are associated with the relevant release milestone.
To be completed by the pull request reviewer once the changes have been reviewed and accepted
The changes have been merged into the base branch (unless there is a specific request not to do so, e.g., they are to be released to SIT).
The issue branch has been deleted (unless the changes have not been merged - see above, or there is a specific request not to do so).
The
In progresslabel has been removed from the pull request.The
Pull requestlabel has been removed from the issue.