Skip to content

Implement LV based on paged WFS reading - #133

Merged
ivorbosloper merged 8 commits into
mainfrom
lv
Dec 10, 2024
Merged

Implement LV based on paged WFS reading#133
ivorbosloper merged 8 commits into
mainfrom
lv

Conversation

@ivorbosloper

@ivorbosloper ivorbosloper commented Dec 3, 2024

Copy link
Copy Markdown
Collaborator

Parse data from the original source (LV Government). This will allow us to add more years to the data collection (EuroCrops now only has 2021).

@ivorbosloper
ivorbosloper requested a review from m-mohr December 3, 2024 14:51
Comment thread fiboa_cli/convert_utils.py
Comment thread fiboa_cli/datasets/lv.py
@m-mohr m-mohr mentioned this pull request Dec 9, 2024

@m-mohr m-mohr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog :-)

I'm inclined to create a PR template that asks to create a changelog entry ;-)

Co-authored-by: Matthias Mohr <matthias@mohr.ws>
@ivorbosloper
ivorbosloper requested a review from m-mohr December 9, 2024 14:01
@ivorbosloper

Copy link
Copy Markdown
Collaborator Author

Changelog :-)

I'm inclined to create a PR template that asks to create a changelog entry ;-)

I'd love that! For every PR that changes more than say 10 lines; changelog.md should contain a some change :)

@m-mohr

m-mohr commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

I was more thinking of a checkbox in the PR description fields (similar to issue templates), but I guess a CI check also works (although a one line change could also be significant) ;-)

@ivorbosloper
ivorbosloper merged commit 5bc2c90 into main Dec 10, 2024
@ivorbosloper
ivorbosloper deleted the lv branch December 10, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants