Skip to content

process, fix: make required envs' kv fallback to the ones of parent process. #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2019
Merged

process, fix: make required envs' kv fallback to the ones of parent process. #516

merged 1 commit into from
Sep 2, 2019

Conversation

richardo2016
Copy link
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request with prefix '(module|object|source_directory) [bugfix|feat|refactor|]', Such as db, bugfix: ..., tools, feat: ...
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with fibjs test.)
  • Ensure commits history clean, merge master/dev and clean meaningless commits by git rebase.

@richardo2016 richardo2016 changed the base branch from master to dev September 2, 2019 14:22
@richardo2016 richardo2016 changed the title Fix/env missing in win32 process, fix: make requried envs' kv fallback to the ones of parent process. Sep 2, 2019
@richardo2016 richardo2016 force-pushed the fix/env_missing_in_win32 branch 3 times, most recently from 21b0b88 to 023813a Compare September 2, 2019 16:14
@richardo2016 richardo2016 force-pushed the fix/env_missing_in_win32 branch from 023813a to 4f92deb Compare September 2, 2019 16:22
@richardo2016 richardo2016 changed the title process, fix: make requried envs' kv fallback to the ones of parent process. process, fix: make required envs' kv fallback to the ones of parent process. Sep 2, 2019
@xicilion xicilion merged commit 6c8a8d0 into fibjs:dev Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richardo2016 @xicilion