-
Notifications
You must be signed in to change notification settings - Fork 8
Fibertig #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FiberTig Branch: PanGenome Support + Boundary Bug Fix
🎯 Overview
This PR introduces the first pangenome support to fibertools-rs while fixing a coordinate mapping bug (Issue #90). The changes add 3 new commands.
🐛 Bug Fix: Issue #90
Problem: Nucleosome/MSP coordinates at alignment block boundaries were incorrectly extended into subsequent blocks, causing artificial length inflation.
🚀 New Features: PanGenome Commands
1.
pg-injectCreate mock BAM files from reference FASTA with perfectly aligned sequences while injecting annotation information from BED files.
3.
pg-pansnAdd/strip panSN-spec prefixes from BAM contig names
2.
pg-liftLift annotations through pangenome graphs from source to target coordinates
vg+pg-pansn+pg-liftunder the hood.📦 New Core Architecture
Major New Modules
fibertig.rs(647 lines) - Core pangenome annotation frameworkbamannotations.rs(573 lines) - BED annotation handling & coordinate mappingpanspec.rs(63 lines) - PanSN specification supportEnhanced Modules
bamlift.rs- Improved coordinate lifting with better error handlingbio_io.rs- Enhanced I/O capabilities (+114 lines)fiber.rs- Major cleanup and simplification (-218 lines)Removed Legacy Code
bamranges.rs(355 lines removed) - Replaced with more efficient implementationsPython (py-ft) Enhancements